Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue reconciliation of all GSLBs that reference the same endpoint #1549

Merged
merged 1 commit into from
May 8, 2024

Conversation

abaguas
Copy link
Collaborator

@abaguas abaguas commented May 1, 2024

The controller watches Endpoint resources to quickly update the health status of GSLBs. When an Endpoint changes, the controller fetches all GSLB resources and checks if they reference this Endpoint. However, there is a bug where the loop only queues for reconciliation the last GSLB that references the Endpoint.
In this PR the bug described above is fixed so that the endpoint handler is capable of queuing multiple GSLB resources for reconciliation.


Manual Test

Best done after setting a long reconcileRequeueSeconds (e.g. 600 seconds) to prevent GSLBs from being reconciled more often.

  • Create multiple GSLBs with different domain names using the same backend service.
  • Scale to 0 the sts/deploy behind the backend service to trigger an update of the endpoints.
  • Verify the DNS records are removed for all GSLB domains.

@abaguas abaguas force-pushed the reconcile/endpoints branch from 97fa1dd to c4181c2 Compare May 1, 2024 19:27
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch!

@ytsarev ytsarev merged commit bbbce9d into k8gb-io:master May 8, 2024
11 checks passed
@abaguas abaguas deleted the reconcile/endpoints branch November 1, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants