Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure secret reference refactoring and enhancement #1593

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jun 9, 2024

  • Explicitly mention azure control variables in the values.yaml for proper visibility and documentation
  • Scope the azure credentials related values under azuredns.createAuthSecret.*
  • Bring up the Azure public DNS doc to README/website frontpage
  • Enhance make deploy-full-local-setup with ability to deploy test k8gb chart and k8gb controller versions
  • Update value examples in the Azure tutorial
  • Fix newline control in -}} templating function to create properly formatted secret
  • Fixes Azure DNS: ability to reference existing secret #1585

All changes tested e2e locally:

  • The azure external secret is getting created with:
azuredns:
  # -- Enable Azure DNS provider
  enabled: true
  # -- Azure tenant ID which holds the managed identity
  createAuthSecret:
    enabled: true
    tenantId: myTenantID
    # -- subscription id which holds the Azure DNS zone
    subscriptionId: mySubscriptionID
    # -- Azure Resource Group which holds the Azure DNS Zone (which is defined as 'edgeDNSZone')
    resourceGroup: k8gb-kubeconeu2023
    aadClientId: myAADClientID
    aadClientSecret: myAADClientSecret
k view-secret -n k8gb external-dns-secret-azure
Choosing key: azure.json
{
  "tenantId": "myTenantID",
  "subscriptionId": "mySubscriptionID",
  "resourceGroup": "k8gb-kubeconeu2023",
  "aadClientId": "myAADClientID",
  "aadClientSecret": "myAADClientSecret",
  "useManagedIdentityExtension": false,
  "userAssignedIdentityID": "myUserAssignedIdentityID",
  "useWorkloadIdentityExtension": false
}

In case of

azuredns:
  # -- Enable Azure DNS provider
  enabled: true
  authSecretName: external-dns-secret-azure-test
  # -- Azure tenant ID which holds the managed identity
  createAuthSecret:
    enabled: false

The external-dns-secret-azure-test was created separately from the helm chart installation and was properly picked up by extenral-dns deployment.

HOW TO RUN CI ---

By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.

Heavy tests

Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.

Debug tests

If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

ytsarev added 4 commits June 9, 2024 13:16
* Fix newlines in secret
* Fix conditions
* Update helm values in tutorial

Signed-off-by: Yury Tsarev <[email protected]>
Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit f4f36cd
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/66663a065e9dd70008cd3259
😎 Deploy Preview https://deploy-preview-1593--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ytsarev ytsarev force-pushed the azure-secret-reference branch from e03094a to 1bf8159 Compare June 9, 2024 23:56
@ytsarev ytsarev merged commit 9fefd2e into k8gb-io:master Jun 11, 2024
12 checks passed
@ytsarev ytsarev deleted the azure-secret-reference branch June 11, 2024 22:32
@ytsarev ytsarev mentioned this pull request Jun 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DNS: ability to reference existing secret
2 participants