Fix external-dns SA definition #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Externaldns Service Account definition was duplicated between coredns and route53 externaldns manifests * Consolidate it in the main one with route53 keeping IRSA annotation
k0da
reviewed
Oct 7, 2020
| @@ -36,6 +26,7 @@ spec: | |||
| - --aws-zone-type=public # only look at public hosted zones (valid values are public, private or no value for both) | |||
| - --registry=txt | |||
| - --txt-owner-id= {{ .Values.route53.hostedZoneID }} | |||
| - --log-level=debug # debug only | |||
There was a problem hiding this comment.
Looks like leftover from debugging
There was a problem hiding this comment.
@k0da yes, by default. It's not super verbose still useful. We are using the same for coredns external-dns instance.
There was a problem hiding this comment.
@ytsarev worth to mention it in a commit message then
There was a problem hiding this comment.
@k0da sorry, missed this one, will document properly during next iteration
kuritka
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and route53 externaldns manifests