Route53 support #172
Merged
Route53 support #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We have common delegated zone per k8gb clusters deployment * Multiple Gslb objects should not override delegated zone config with different NS server names * Thus consolidate the NS server names over multiple Gslbs
* We don't need to duplicate NS records over multiple k8gb instances as it is DNS zone wide configuration common for all Gslb objects * Drawback: multiple Gslb objects will be writing the same data into this DNSEndpoint * Advantage: we avoid creating additional Reconciliation loop and additional configuration CRD to handle this situation
Additionally simplify external-dns params
* Introduce Dig function * Resolve AWS NLB fqdn which is associated with coredns service exposure * Populate NS Server A record with resolution results
To avoid potential collisions and to be more clear and explicit in NS server FQDN
* Fixing full local setup * Fixing Terratest
kuritka
approved these changes
Oct 15, 2020
somaritane
reviewed
Oct 15, 2020
| reconcileRequeueSeconds: 30 | ||
|
|
||
| externaldns: | ||
| image: k8s.gcr.io/external-dns/external-dns:v0.7.4 | ||
| image: absaoss/external-dns:v0.7.1-401-gede9767c # temporary image containing NS record support before the merge of https://github.com/kubernetes-sigs/external-dns/pull/1813 | ||
| interval: "20s" | ||
| expose53onWorkers: true # open 53/udp on workers nodes with nginx controller |
There was a problem hiding this comment.
probably can use known port name instead of number, like exposeUdpOnWorkers
There was a problem hiding this comment.
cat /etc/services |grep 53/udp|head
domain 53/udp # Domain Name Server
53 is more clear and explicit imho. Like in Route53 naming itself lol
somaritane
approved these changes
Oct 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS Route53 as EdgeDNS.
Notable differences comparing on-prem setup with Infoblox:
Note:
TXT based split brain control is skipped for now - the mechanism might be rethought given we are moving from direct API calls to edgeDNS to full utilization of external-dns capabilities ( Custom TXT creation is also lacking there as of now )