Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate controller tests #176

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Isolate controller tests #176

merged 2 commits into from
Oct 22, 2020

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Oct 22, 2020

Close (#136); related to (#170)
To integrate depresolver with GSLB controller (#170) I must split large controller test into small independent units.

Tests:

  • TestNotFoundServiceStatus
  • TestUnhealthyServiceStatus
  • TestIngressHostsPerStatusMetricReflectionForHealthyStatus
  • TestIngressHostsPerStatusMetricReflectionForUnhealthyStatus
  • TestIngressHostsPerStatusMetricReflectionForNotFoundStatus,
  • TestIngressHostsPerStatusMetricReflectionForUnhealthyStatus
  • TestHealthyRecordMetric
  • TestMetricLinterCheck
  • TestGslbCreatesDNSEndpointCRForHealthyIngressHosts
  • TestDNSRecordReflectionInStatus
  • TestLocalDNSRecordsHasSpecialAnnotation
  • TestGeneratesProperExternalNSTargetFQDNsAccordingToTheGeoTags
  • TestCanGetExternalTargetsFromK8gbInAnotherLocation
  • TestCanCheckExternalGslbTXTRecordForValidityAndFailIfItIsExpired
  • TestCanFilterOutDelegatedZoneEntryAccordingFQDNProvided, TestCanGenerateExternalHeartbeatFQDNs
  • TestReturnsOwnRecordsUsingFailoverStrategyWhenPrimary
  • TestReturnsExternalRecordsUsingFailoverStrategy
  • TestGslbProperlyPropagatesAnnotationDownToIngress
  • TestReflectGeoTagInStatusAsUnsetByDefault
  • TestReflectGeoTagInTheStatus
  • TestDetectsIngressHostnameMismatch
  • TestCreatesNSDNSRecordsForRoute53
  • TestResolvesLoadBalancerHostnameFromIngressStatus
  • TestCanCheckExternalGslbTXTRecordForValidityAndPAssIfItISNotExpired

…erviceStatus

 - TestUnhealthyServiceStatus
 - TestIngressHostsPerStatusMetricReflectionForHealthyStatus
 - TestIngressHostsPerStatusMetricReflectionForUnhealthyStatus
 - TestIngressHostsPerStatusMetricReflectionForNotFoundStatus, TestIngressHostsPerStatusMetricReflectionForUnhealthyStatus
 - TestHealthyRecordMetric; TestMetricLinterCheck
 - TestGslbCreatesDNSEndpointCRForHealthyIngressHosts
 - TestDNSRecordReflectionInStatus
 - TestLocalDNSRecordsHasSpecialAnnotation
 - TestGeneratesProperExternalNSTargetFQDNsAccordingToTheGeoTags
 - TestCanGetExternalTargetsFromK8gbInAnotherLocation
 - TestCanCheckExternalGslbTXTRecordForValidityAndFailIfItIsExpired
 - TestCanFilterOutDelegatedZoneEntryAccordingFQDNProvided, TestCanGenerateExternalHeartbeatFQDNs
 - TestReturnsOwnRecordsUsingFailoverStrategyWhenPrimary
 - TestReturnsExternalRecordsUsingFailoverStrategy
 - TestGslbProperlyPropagatesAnnotationDownToIngress
 - TestReflectGeoTagInStatusAsUnsetByDefault
 - TestReflectGeoTagInTheStatus
 - TestDetectsIngressHostnameMismatch
 - TestCreatesNSDNSRecordsForRoute53
 - TestResolvesLoadBalancerHostnameFromIngressStatus
 - TestCanCheckExternalGslbTXTRecordForValidityAndPAssIfItISNotExpired
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuritka incredible job, thanks man !

@Zak-Anderson
Copy link

Really awesome 👍

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kuritka kuritka merged commit 72956bd into master Oct 22, 2020
@kuritka kuritka changed the title Izolate controller tests Isolate controller tests Oct 22, 2020
@kuritka kuritka deleted the 136-tests-isolated branch October 27, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants