Readme revamp and Route53 tutorial #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ytsarev
commented
Oct 24, 2020
•
ytsarev
commented
- Split README to readable sections
- Create CONTRIBUTING.md
- Create CODEOWNERS
- Add Route53 tutorial together with reference terraform code, sample k8gb values yaml files and Gslb sample CR
* Splitting to sections * Create placeholders for important enhancements
|
guys, it is WIP, would love to get early feedback on the overall direction with docs @somaritane it's inline with what we discussed in person |
ytsarev
force-pushed
the
readme-revamp
branch
from
3186c54 to
9200062
Compare
kuritka
requested changes
Oct 26, 2020
|
|
||
| For more advanced technical documentation and fully automated local installation steps, see below. | ||
| * Load balancing is based on timeproof DNS protocol which is perfect for global scope and extremely reliable |
There was a problem hiding this comment.
Suggested change
| * Load balancing is based on timeproof DNS protocol which is perfect for global scope and extremely reliable | |
| * Load balancing is based on time proof DNS protocol which is perfect for global scope and extremely reliable |
There was a problem hiding this comment.
@kuritka not sure here, used as adjective https://en.wiktionary.org/wiki/timeproof . @donovanmuller please comment as a native speaker, thanks
There was a problem hiding this comment.
Hey @ytsarev - is there anything we can link to that describes the DNS timeproof protocol? Google is failing me.
| 172.17.0.7 | ||
| ``` | ||
| * One of your workers should already return DNS responses constructed by Gslb based on service health information | ||
| * If edgeDNS was configured you can query your standard infra DNS directly and it should return the same |
There was a problem hiding this comment.
Suggested change
| * If edgeDNS was configured you can query your standard infra DNS directly and it should return the same | |
| * If edgeDNS was configured, you can query your standard infra DNS directly and it should return the same |
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
Co-authored-by: MichalK <[email protected]>
|
@kuritka cool stuff, thanks a ton for review |
* Add the doc * Add the sample reference terraform code * Add the sample k8gb values yaml * Additionally make some minor fix to values.yaml
donovanmuller
approved these changes
Oct 26, 2020
kuritka
approved these changes
Oct 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.