Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch source of addresses for A records to Ingress #18

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 3, 2020

  • Instead of manually resolve worker healthiness use information
    from Ingress status:
$ k get ing
NAME        HOSTS                                                                           ADDRESS      PORTS   AGE
test-gslb   app.cloud.absa.internal,app2.cloud.absa.internal,app3.cloud.absa.internal   172.17.0.2   80      18h
  • Assuming properly configured Ingress controller Address in status
    should be always populated
  • Ingress Address can be either worker nodes or load balancer depending
    on specific cluster and ingress controller configuration so we properly
    abstract it

* Instead of manually resolve worker healthiness use information
  from Ingress status:
```
$ k get ing
NAME        HOSTS                                                                           ADDRESS      PORTS   AGE
test-gslb   app.cloud.absa.internal,app2.cloud.absa.internal,app3.cloud.absa.internal   172.17.0.2   80      18h
```
* Assuming properly configured Ingress controller Address in status
should be always populated
* Ingress Address can be either worker nodes or load balancer depending
on specific cluster and ingress controller configuration so we properly
abstract it
@ytsarev ytsarev requested a review from donovanmuller January 3, 2020 11:31
@ytsarev ytsarev merged commit 1a6b6bb into master Jan 3, 2020
@ytsarev ytsarev deleted the ingress_addresses branch January 3, 2020 11:43
ytsarev added a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants