Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm release pipeline #188

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix Helm release pipeline #188

merged 1 commit into from
Oct 28, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Oct 28, 2020

Recently I introduced linting as dependency
for test and docker build in Makefile.

It is very useful for local developer productivity,
unfortunately it broke the release pipe given linting
tools are not presented on github action runner.

Let's fix that to install them with go get

Recently I introduced linting as dependency
for test and docker build in Makefile.

It is very useful for local developer productivity,
unfortunately it broke the release pipe given linting
tools are not presented on github action runner.

Let's fix that to install them with `go get`
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ytsarev ytsarev merged commit 357e380 into master Oct 28, 2020
@ytsarev ytsarev deleted the helm-release-fix-pipe branch October 28, 2020 12:52
@kuritka
Copy link
Collaborator

kuritka commented Oct 29, 2020

@ytsarev I did a brief investigation and we can extend our lint command with

.PHONY: lint
lint:
	staticcheck ./...
	errcheck ./...
	golint '-set_exit_status=1' ./...
	@if [ $(shell goimports -l ./ | wc -l | tr -d '[:space:]') -ge 1 ]; then (echo 'goimports -l ./ \nrun "goimports -l -w ./" to fix formatting or unsorted imports'; exit 1); else echo 'goimports -l ./'; fi

with output:

❯ make lint
staticcheck ./...
errcheck ./...
golint '-set_exit_status=1' ./...
goimports -l ./ 
run "goimports -l -w ./" to fix formatting or unsorted imports
make: *** [lint] Error 1

@ytsarev
Copy link
Member Author

ytsarev commented Oct 29, 2020

@kuritka looks useful, though the shell part is a little bit scary :)

@kuritka
Copy link
Collaborator

kuritka commented Oct 29, 2020

yeah, shell part is crazy :( Unfortunately I found nothing better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants