Integrate depresolver #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close(#170) All inputs are now loaded during init time, instead of runtime. Inputs are loaded once and vilidated. Any input is accessible from the (single surce of truth)[https://en.wikipedia.org/wiki/Single_source_of_truth]: `.Config` found in receiver `*GslbReconciler`. Making Route53Enabled private. transfered env vars: - DNS_ZONE - EXT_GSLB_CLUSTERS_GEO_TAGS - CLUSTER_GEO_TAG - EDGE_DNS_SERVER - INFOBLOX_GRID_HOST - INFOBLOX_WAPI_VERSION - INFOBLOX_WAPI_PORT - EXTERNAL_DNS_INFOBLOX_WAPI_USERNAME - EXTERNAL_DNS_INFOBLOX_WAPI_PASSWORD - OVERRIDE_WITH_FAKE_EXT_DNS - OVERRIDE_WITH_FAKE_EXT_DNS - EDGE_DNS_ZONE - FAKE_INFOBLOX remove Route53Enabled from execution code
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close(#170)
We now load all inputs during init time, instead of runtime.
Inputs are loaded once and validated. Any input is accessible from the
single source of truth:
.Configfound in receiver
*GslbReconciler.Making Route53Enabled private.
transferred env vars: