Use absolute URLs in case of file reference #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
Unfortunately relative paths are not working in Github Pages leading to 404 in cases when we reference file/dir in the github repository. So unless the referenced file is md or a graphic file like png/svg we have to stick with the absolute url to the master branch
ytsarev
force-pushed
the
absolute-urls
branch
from
dcbdf55 to
b4cf799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately relative paths are not working in Github Pages
leading to 404 in cases when we reference file/dir in the github
repository.
So unless the referenced file is md or a graphic file like png/svg
we have to stick with the absolute url to the master branch