Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to golangci-lint #198

Merged
merged 1 commit into from
Nov 2, 2020
Merged

switch to golangci-lint #198

merged 1 commit into from
Nov 2, 2020

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Nov 2, 2020 •
edited
Loading

closes #197

  • Github workflow switched to golang-ci (switch to recommended golangci-lint pipeline)
  • minor syntax changes required by extended linters
  • remove gosec pipeline
  • update Makefile lint
  • release.yaml remove [golint, gosec, errcheck]. Installing golangci-lint v1.32.0 instead.
  • no changes in Documentation needed

@kuritka
switch build to golangci
069951f 
 - remove gosec pipeline
 - update Makefile lint
 - build pipeline switched to golang-ci
 - code fixing after extending new linters
 - `release.yaml` remove [golint, gosec, errcheck]. Installing `golangci-lint v1.32.0` instead
ytsarev
ytsarev approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, thanks a lot 👍

@kuritka kuritka merged commit 4c55a1b into master Nov 2, 2020
@kuritka kuritka deleted the 186-integrate-with-golangci branch November 3, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch linters to golang-ci
2 participants
@kuritka @ytsarev