Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use AbsaOSS/gopkg #199

Merged
merged 1 commit into from
Nov 2, 2020
Merged

use AbsaOSS/gopkg #199

merged 1 commit into from
Nov 2, 2020

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Nov 2, 2020

closes #185

@k0da, @somaritane - please reuse shell, env within your projects - github.com/AbsaOSS/gopkg v0.0.1.

k0da
k0da approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuritka kuritka merged commit c80727f into master Nov 2, 2020
@kuritka kuritka deleted the 185-gopkg branch November 3, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@k0da k0da k0da approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split of pkg/internal/env into reusable pkg
3 participants
@kuritka @ytsarev @k0da