Simplify Makefile #201
Merged
Simplify Makefile #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
109-makefile-rfctr
branch
2 times, most recently
from
1c58cba to
0bb1e0c
Compare
somaritane
suggested changes
Nov 12, 2020
deploy-full-local-setup fix localtargets name in documentation local playground passed wait deploy-gslb-operator-14 k8gb terratest, moving to makefile terratest-pipeline fix #1 terratest-pipeline fix #2 terratest-pipeline fix #3 terratest-pipeline fix #4 terratest-pipeline fix #5 move stable repo location from https://kubernetes-charts.storage.googleapis.com to https://charts.helm.sh/stable see: https://helm.sh/blog/new-location-stable-incubator-charts/ highlight large script sections fix version fix version #2 fix version #3 fix version #4 simplify release pipeline, move logic to Makefile fix terratest by adding image-repo between deploy-local-cluster args registry.sh #1 registry.sh; installing docker registry always in deploy-full-terratest-setup; remove registry.sh remove full.sh, remove registry.sh test; functionality, hide generate, controller gent, manifest remove GOPATH guardian as GO terraform-test runs clean ubuntu image, no GOLANG image refactor generate and manifest move kustomize run manager install infoblox-secret retreive version from shell , deploy fix deploy, remove kustomize udf bundle build-bundle, debug-local docker-test-build-push change git-last-commit-hash into shell COMMIT_HASH lowercase comments alphabetically sort targets remove deploy, bundle, bundle-build remove debug-local and create debug-local-idea instead refactor debug-local-idea to debug-idea refactor debug-local-idea to debug-idea
kuritka
force-pushed
the
109-makefile-rfctr
branch
from
0bb1e0c to
1d7a2aa
Compare
ytsarev
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #109
All maintenance logic is within one
Makefilenow.full.sh,registry.shK8GB deploymentintoMakefilehttps://kubernetes-charts.storage.googleapis.comtohttps://charts.helm.sh/stabledeploy-full-local-setup,deploy-full-terratest-setupReport
make <target>crossed out- functionality moved to new Makefile but not accessible via targets (no reason to expose)old
bundleREMOVED , obsolete by 1.0 migrationbundle-buildREMOVED , obsolete by 1.0 migrationcontroller-gen(kubebuilder initial)create-k8gb-nscreate-test-nsdebug-test-local-> debug-idea new implementationdeploy-first-k8gbdeploy-gslb-crdeploy-gslb-operatordeploy-local-clusterREMOVEDdeploy-local-ingressdeploy-second-k8gbdeploy-test-appsdeploy-two-local-clustersdestroy-local-clusterREMOVEDdestroy-two-local-clustersfmtis part of golangci, using lint instead, REMOVED; (kubebuilder initial)generate(kubebuilder initial)kustomizemanifests(kubebuilder initial)use-first-contextuse-second-contextvetis part of golangci, using lint instead REMOVED; (kubebuilder initial)wait-for-gslb-readywait-for-nginx-ingress-readynew