Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Gslb with Ingress Annotation #205

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Enable Gslb with Ingress Annotation #205

merged 5 commits into from
Nov 23, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Nov 20, 2020

  • Resolves Add ability to reuse existing Ingress #200
  • Reacts to Ingresses with specific annotations
  • Dynamically creates Gslb resources according to annotation contents
  • Associated unit and terratests
  • Brief documentation

@ytsarev ytsarev force-pushed the mighty-annotation branch 2 times, most recently from 5349f2c to 6b69437 Compare November 20, 2020 15:48
@ytsarev
Enable Gslb with Ingress Annotation
bfbcff2 
* Resolves #200
* Reacts to Ingresses with specific annotations
* Dynamically creates Gslb resources according to annotation contents
* Associated unit and terratests
* Brief documentation
donovanmuller
donovanmuller previously approved these changes Nov 23, 2020
View reviewed changes
kuritka
kuritka previously approved these changes Nov 23, 2020
View reviewed changes
@ytsarev ytsarev dismissed stale reviews from kuritka and donovanmuller via 86260ff November 23, 2020 09:27
@ytsarev ytsarev requested a review from kuritka November 23, 2020 09:29
kuritka
kuritka requested changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reuse also in dnsupdate.go

@ytsarev ytsarev requested a review from kuritka November 23, 2020 09:40
ytsarev and others added 2 commits November 23, 2020 10:40
@ytsarev ytsarev requested a review from somaritane November 23, 2020 10:40
somaritane
somaritane approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ytsarev ytsarev merged commit a6f64f2 into master Nov 23, 2020
@ytsarev ytsarev deleted the mighty-annotation branch November 23, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somaritane somaritane somaritane approved these changes

@kuritka kuritka kuritka approved these changes

@donovanmuller donovanmuller donovanmuller left review comments

@k0da k0da Awaiting requested review from k0da k0da is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to reuse existing Ingress
4 participants
@ytsarev @somaritane @donovanmuller @kuritka