Admiralty integration tutorial #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
Provides short demo local setup of k8gb working together with admiralty.io
donovanmuller
previously approved these changes
Dec 7, 2020
kuritka
previously approved these changes
Dec 7, 2020
somaritane
suggested changes
Dec 7, 2020
docs/admiralty.md
Outdated
| ... | ||
| ``` | ||
|
|
||
| Observe that pods were scheduled to Target cluster after then Annotation patch |
There was a problem hiding this comment.
Suggestion just in order to be consistent with beginning of tutorial, 'target' is used with small caps there.
Suggested change
| Observe that pods were scheduled to Target cluster after then Annotation patch | |
| Observe that pods were scheduled to the target clusters after the application of Annotation patch. |
There was a problem hiding this comment.
or maybe vice versa for capital? As for
apiVersion: multicluster.admiralty.io/v1alpha1
kind: Target
There was a problem hiding this comment.
sure thing, just needs to be capital everywhere for consistency 👍
docs/admiralty.md
Outdated
|
|
||
| ## Add pod annotations to enable multi-cluster scheduling | ||
|
|
||
| Edit `podinfo` Deployment to add admiralty `multicluster.admiralty.io/elect` scheduling Annotation to Pod spec template |
There was a problem hiding this comment.
Suggested change
| Edit `podinfo` Deployment to add admiralty `multicluster.admiralty.io/elect` scheduling Annotation to Pod spec template | |
| Edit `podinfo` Deployment to add Admiralty `multicluster.admiralty.io/elect` scheduling Annotation to Pod spec template |
ytsarev
dismissed stale reviews from k0da, kuritka, and donovanmuller
via
d42937c
|
@somaritane thanks a ton for the thorough review, please check again |
kuritka
approved these changes
Dec 14, 2020
|
https://github.com/admiraltyio/admiralty/releases/tag/v0.13.2 ingress annotation trigger released so we can merge this doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides short demo local setup of k8gb working
together with admiralty.io