k3d migration #218
Merged
k3d migration #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
|
@kuritka could you please rebase with master. Going to thoroughly test it with recent codebase |
kuritka
force-pushed
the
141-switch-to-k3d
branch
from
cb605b0 to
8e129a7
Compare
ytsarev
requested changes
Dec 15, 2020
- create k3d github action - remove private registry from makefile - remove kind config yamls - update makefile - update tests k3d - update documentation to k3d, change number of returned nodes in `dig @localhost localtargets-app3.cloud.example.com` from three to four - upgrade podinfo version - specify underlying docker bridge network (requires by k3d) - refactor GitHub `terratest.yaml` workflow, currently running against @main until v1.0.0 will be released - refactor and test `release.yaml` workflow to use k3d action with single cluster, no private docker registry - set workflow to the newest ubuntu-20.04. For more details, see actions/runner-images#1816 - https://github.com/AbsaOSS/k8gb/blob/master/docs/local.md passed
kuritka
force-pushed
the
141-switch-to-k3d
branch
from
8e129a7 to
6889b30
Compare
ytsarev
approved these changes
Dec 15, 2020
|
Amazing, so let's merge it and cut-off the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #141
dig @localhost localtargets-app3.cloud.example.comfrom three to fourterratest.yamlworkflow, currently running against @main until v1.0.0 will be releasedrelease.yamlworkflow to use k3d action with single cluster, no private docker registry