Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update absaoss/k8s_crd CoreDNS plugin to v0.0.2 #326

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Update absaoss/k8s_crd CoreDNS plugin to v0.0.2 #326

merged 1 commit into from
Feb 27, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Feb 27, 2021

This brings RecortTTL and aarch64 architecture support
(absaoss/k8s_crd:v0.0.2)

kuritka
kuritka previously approved these changes Feb 27, 2021
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend PR title with CoreDNS plugin name (absaoss/k8s_crd) and version (v0.0.2).

@k0da
Copy link
Collaborator Author

k0da commented Feb 27, 2021

@somaritane isn't this visible from a change?

@somaritane
Copy link
Contributor

somaritane commented Feb 27, 2021

@somaritane isn't this visible from a change?

@k0da It is good practice to reflect the essence of PR or commit in its title.
Dependabot's produced PRs are good examples on how dependency update change title can be formatted:
https://github.com/AbsaOSS/k8gb/pull/321

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k0da, can you please amend PR title and commit message title (1st line)?
The suggested text is:
Update absaoss/k8s_crd CoreDNS plugin to v0.0.2
Thanks.

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k0da, can you please amend PR title and commit message title (1st line)?
The suggested text is:
Update absaoss/k8s_crd CoreDNS plugin to v0.0.2
Thanks.

This brings RecortTTL and aarch64 architecture support
(absaoss/k8s_crd:v0.0.2)

Signed-off-by: Dinar Valeev <[email protected]>
@k0da k0da requested a review from somaritane February 27, 2021 17:06
@k0da k0da changed the title Update CoreDNS plugin Update absaoss/k8s_crd CoreDNS plugin to v0.0.2 Feb 27, 2021
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@k0da k0da merged commit 3a561ea into master Feb 27, 2021
@somaritane somaritane deleted the arm branch March 9, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants