Remove udp-services ConfigMap from k8gb helm chart templates
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaritane
requested review from
donovanmuller,
k0da,
kuritka and
ytsarev
as code owners
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
efeaa2c to
47e2f9c
Compare
ytsarev
requested changes
Mar 6, 2021
|
Aslo this PR will close https://github.com/AbsaOSS/k8gb/issues/323 |
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
47e2f9c to
9fb3e33
Compare
ytsarev
requested changes
Mar 10, 2021
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
9fb3e33 to
724da62
Compare
somaritane
changed the title
upd-services ConfigMap from k8gb helm chart templatesudp-services ConfigMap from k8gb helm chart templates
k0da
requested changes
Mar 10, 2021
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
724da62 to
397c949
Compare
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
0a1d5fe to
0bd6ca7
Compare
@donovanmuller , thanks, updated! |
k0da
reviewed
Mar 11, 2021
k0da
previously approved these changes
Mar 11, 2021
- Removed NGINX Ingress Controller `udp-services` ConfigMap from k8gb chart templates. - Updated k8gb documentation and example values files in order to reflect removal. - Created documentation explaining DNS traffic configuration - Amended general and local setup documentation
somaritane
force-pushed
the
remove-udp-services-from-helm
branch
from
4ff41c5 to
578bc79
Compare
k0da
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
udp-servicesConfigMap from k8gb chart templates.This PR closes #352 and #323