Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 documentation fixes #373

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Route53 documentation fixes #373

merged 5 commits into from
Mar 18, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Mar 17, 2021

  • Ingess installation was missing

  • Make targets could trigger incompatible chart
    modification from master branch

  • Wrong instruction for Gslb CR

Signed-off-by: Yury Tsarev [email protected]

* Ingess installation was missing

* Make targets could trigger incompatible chart
  modification from `master` branch

* Wrong instruction for Gslb CR

Signed-off-by: Yury Tsarev <[email protected]>
somaritane
somaritane previously approved these changes Mar 17, 2021
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor hint added

Co-authored-by: Timofey Ilinykh <[email protected]>
@ytsarev ytsarev merged commit 2bd173e into master Mar 18, 2021
@ytsarev ytsarev deleted the route53-docs branch March 18, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants