Generation tools improvements #375
Conversation
somaritane
commented
Mar 18, 2021
•
somaritane
commented
- boilerplate.go.txt template is restored and handled by golic
- Local .golic.yaml used to override golic global settings
- apache2 license is specified explicitly instead of relying on default golic value
- controller-gen version is aligned with OperatorSDK 1.3.0
- tools are auto-installed with go install
- make help is default target
- go v1.16 is now required for local setup (TODO v1.16 code upgrade will be done in separate PR )
somaritane
requested review from
donovanmuller,
k0da,
kuritka and
ytsarev
as code owners
somaritane
force-pushed
the
gen-tools-improvements
branch
from
dcd9c9b to
5f45684
Compare
somaritane
force-pushed
the
gen-tools-improvements
branch
from
5f45684 to
132e783
Compare
Makefile
Outdated
| license: golic | ||
| $(GOLIC) inject -c "2021 Absa Group Limited" | ||
| license: | ||
| $(call golic,--dry -t apache2) |
There was a problem hiding this comment.
iirc it was suggested as precaution by @kuritka, so that make license target only indicates changes but not writes to files.
There was a problem hiding this comment.
@somaritane , license target must modify files (if file is new inject license automatically). Don't know in which context we were talking about. Sorry if there was some misunderstandings caused by me.
There was a problem hiding this comment.
So --dry should be removed here, correct?
There was a problem hiding this comment.
So
--dryshould be removed here, correct?
@ytsarev , yes should be removed
There was a problem hiding this comment.
👍 thanks for clarification @kuritka ! will amend.
Makefile
Outdated
| license: golic | ||
| $(GOLIC) inject -c "2021 Absa Group Limited" | ||
| license: | ||
| $(call golic,--dry -t apache2) |
There was a problem hiding this comment.
@somaritane , license target must modify files (if file is new inject license automatically). Don't know in which context we were talking about. Sorry if there was some misunderstandings caused by me.
somaritane
force-pushed
the
gen-tools-improvements
branch
from
dc73a2e to
378e227
Compare
Makefile
Outdated
| license: golic | ||
| $(GOLIC) inject -c "2021 Absa Group Limited" | ||
| license: | ||
| $(call golic,--dry -t apache2) |
There was a problem hiding this comment.
So --dry should be removed here, correct?
- boilerplate.go.txt template is restored and handled by golic - Local .golic.yaml used to override golic global settings - apache2 license is specified explicitly instead of relying on default golic value - controller-gen version is aligned with OperatorSDK 1.3.0 - tools are auto-installed with go install - make help is default target - go v1.16 is now required for local setup (TODO v1.16 code upgrade will be done in separate PR )
somaritane
force-pushed
the
gen-tools-improvements
branch
from
066f601 to
8d3ad55
Compare
@ytsarev thanks for pointing, done |
