Fix changelog in Release #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
kuritka
previously approved these changes
Mar 18, 2021
ytsarev
requested changes
Mar 18, 2021
.github/workflows/release.yaml
Outdated
| previous_tag=$(git tag --sort=v:refname | tail -2 | head -1) | ||
| current_tag=$(git tag --sort=v:refname | tail -1) | ||
| echo "::set-output name=previous_tag::${previous_tag}" | ||
| echo "::set-output name=current_tag::${current_tag}" |
There was a problem hiding this comment.
I do not see the usage of current_tag here. So we can remove it and leave only previous_tag around
Switch to proved to work solution Signed-off-by: Dinar Valeev <[email protected]>
ytsarev
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to proved to work solution
Signed-off-by: Dinar Valeev [email protected]