Rollback external-dns to get NS record creation back #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* external-dns `v0.7.6` included https://github.com/kubernetes-sigs/external-dns/pull/1915/files * Even with `--managed-record-types=A,CNAME,NS` it silently skips NS record type creation * `test.k8gb.io` NS record was staying orphaned and undeleted in reference setup configuration making an illusion that everything is properly working with route53 based zone delegation * Switch back to reliable `v0.7.5` where NS record support was introduced at kubernetes-sigs/external-dns#1813 Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
k0da
approved these changes
Mar 20, 2021
somaritane
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.7.6included https://github.com/kubernetes-sigs/external-dns/pull/1915/files--managed-record-types=A,CNAME,NSit silently skips NSrecord type creation
test.k8gb.ioNS record was staying orphaned and undeleted in reference setupconfiguration making an illusion that everything is properly working
with route53 based zone delegation
v0.7.5where NS record support was introducedat Add NS record support kubernetes-sigs/external-dns#1813
Signed-off-by: Yury Tsarev [email protected]