HTTP ingress rule value is Mandatory #402
Conversation
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
ingress-mandatory-http
branch
from
84dd9e8 to
8aedea5
Compare
|
@k0da amended |
There was a problem hiding this comment.
From https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
The v1.22 release will stop serving the following deprecated API versions in favor of newer and more stable API versions:
Ingress in the extensions/v1beta1 API version will no longer be served
Migrate to use the networking.k8s.io/v1beta1 API version, available since v1.14. Existing persisted data can be retrieved/updated via the new version.
So we should stick with networking.k8s.io/v1beta1
|
@kuritka IMO we can do both |
kuritka
force-pushed
the
ingress-mandatory-http
branch
4 times, most recently
from
ccb22d0 to
6983551
Compare
|
@ytsarev @k0da @somaritane , I succesfully migrated to This one is making just in case: In second PR I will change CRD. |
kuritka
force-pushed
the
ingress-mandatory-http
branch
from
6983551 to
56e6ea1
Compare
api/v1beta1/types.go
Outdated
| @@ -0,0 +1,196 @@ | |||
| /* | |||
There was a problem hiding this comment.
What is the filename semantics? types vs gslb_types?
There was a problem hiding this comment.
@ytsarev good question,
It lives originally in k8s.io/api/extensions/v1beta1/types.go.
There was a problem hiding this comment.
Renamed, was just following original convention upstream_types.go is well descriptive.
api/v1beta1/types.go
Outdated
| "k8s.io/api/extensions/v1beta1" | ||
| ) | ||
|
|
||
| type IngressSpec struct { |
There was a problem hiding this comment.
Can we reference the upstream source of IngressSpec for future?
There was a problem hiding this comment.
@ytsarev , good idea, amended
kuritka
force-pushed
the
ingress-mandatory-http
branch
3 times, most recently
from
e4b9c92 to
affa432
Compare
- the custom structures with mandatory field overrides IngressSpec and and implements necessary routines like DeepCopy and transformations between `k8gbv1beta1` and `v1beta1` - controller-gen created `DeepCopy()` functions in `zz_generated.deepcopy.go` Co-authored-by: Yury Tsarev <[email protected]>
kuritka
force-pushed
the
ingress-mandatory-http
branch
from
1c67553 to
e62e0ed
Compare
related to #401
the custom structures with mandatory field overrides
IngressSpecandand implements necessary routines like
DeepCopyIntoand transformations betweenk8gbv1beta1andv1beta1controller-gen created
DeepCopy()functions inzz_generated.deepcopy.go