Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split changelog PR off helm publish workflow #403

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Split changelog PR off helm publish workflow #403

merged 1 commit into from
Mar 22, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Mar 22, 2021

Split publish jobs into two independed worflows

Signed-off-by: Dinar Valeev [email protected]

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k0da lgtm, just a small title suggestion

Split publish jobs into two independed worflows

Signed-off-by: Dinar Valeev <[email protected]>
Co-authored-by: Timofey Ilinykh <[email protected]>
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@k0da k0da merged commit 13e6e7a into master Mar 22, 2021
@ytsarev
Copy link
Member

ytsarev commented Mar 22, 2021

@k0da @somaritane there is still a chance of race condition/deviation for offline CHANGELOG.md. https://docs.github.com/en/actions/guides/storing-workflow-data-as-artifacts might be a way to enhance it

@k0da k0da deleted the publish branch May 6, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants