Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging for missing environment variables #413

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Improve logging for missing environment variables #413

merged 1 commit into from
Mar 26, 2021

Conversation

somaritane
Copy link
Contributor

  • Use real env variable names instead of internal variables in errors
  • Fix make run target for missing environment variables

@somaritane
Improve logging for missing environment variables
17df5a5 
- Use real env variable names instead of internal variables in errors
- Fix `make run` target for missing environment variables
kuritka
kuritka approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, thx 👍

@somaritane somaritane merged commit 9aabc1b into master Mar 26, 2021
@somaritane somaritane deleted the improve-envvars-logging branch March 26, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@kuritka kuritka kuritka approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somaritane @ytsarev @kuritka