Migration to networking.k8s.io/v1beta1 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
reviewed
Apr 1, 2021
kuritka
force-pushed
the
bump-to-networking-v1beta1
branch
from
665cacc to
0e067ff
Compare
k0da
previously approved these changes
Apr 6, 2021
|
@kuritka it's an api group change, if the automation is not yet there we need to at least test the upgrade from previous version manually |
kuritka
force-pushed
the
bump-to-networking-v1beta1
branch
from
0e067ff to
3949923
Compare
- migration gslb_types and upstream_types to `networking/v1beta1` - migration yamls in terratest, generates warnings see: [terratest #840](gruntwork-io/terratest#840 (comment)) - migration apiGroup in roles - **CRD change** closes #401 Signed-off-by: kuritka <[email protected]>
kuritka
force-pushed
the
bump-to-networking-v1beta1
branch
from
3949923 to
74c3397
Compare
k0da
approved these changes
Apr 9, 2021
@ytsarev , upgrade test + local playground test passed |
ytsarev
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networking/v1beta1CRD change(is already done by Extend Gslb CRD with additionalPrinterColumns #425)closes #401