golint, check capitalized error strings #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check capitalized error strings I'm adding golint min-confidence=0 https://github.com/golang/go/wiki/CodeReviewComments#error-strings As you can see, min-confidence=0 didn't found any issues on our master branch. *Golint makes suggestions for many of the mechanically checkable items listed in [Effective Go](https://golang.org/doc/effective_go) and the [CodeReviewComments](https://github.com/golang/go/wiki/CodeReviewComments) wiki page.* Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
changed the title
somaritane
approved these changes
Apr 22, 2021
k0da
approved these changes
Apr 22, 2021
ytsarev
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check capitalized error strings I'm adding golint
min-confidence=0https://github.com/golang/go/wiki/CodeReviewComments#error-strings
As you can see,
min-confidence=0didn't found any issues on our master branch 💯 .Golint makes suggestions for many of the mechanically checkable items listed in
Effective Go and the CodeReviewComments wiki page.
Signed-off-by: kuritka [email protected]