refactor (3/3): Introducing local FakeDNS #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
ytsarev
reviewed
May 31, 2021
There was a problem hiding this comment.
Just one comment above.
Overall looks really clean and manageable. Is it a candidate for https://github.com/AbsaOSS/gopkg/ in the future? Can be reused outside of k8gb
| fqdn := strings.Split(rr.String(), "\t")[0] | ||
| if fqdn == r.Question[0].Name { | ||
| msg.Answer = append(msg.Answer, rr) | ||
| // msg.Extra = append(msg.Extra, rr) |
I removed global fake DNS from controller and replaced it by local dns server from utils. I fixed controller unit tests to be interracting with local FakeDNS instances. Signed-off-by: kuritka <[email protected]>
kuritka
force-pushed
the
refactor-FakeDNS2
branch
from
47dbf07 to
d20c1d9
Compare
|
@ytsarev , amended. 💯 it will go to gopkg. The idea is to make it run for a while in k8gb. Maybe some changes will need to be implemented and when it settles down a bit, we'll move it into gopkg. |
ytsarev
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed global fake DNS from controller and replaced it by local DNS server from utils.
I fixed controller unit tests to be interacting with local FakeDNS instances.
Signed-off-by: kuritka [email protected]