Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use edgeDNSServer for NS name resolution #516

Merged
merged 7 commits into from
Jun 8, 2021
Merged

Use edgeDNSServer for NS name resolution #516

merged 7 commits into from
Jun 8, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jun 8, 2021

  • Use edgeDNSServer for NS name resolution with the fallback to the local nameserver
  • Supporting dns related functions
  • Logs to stdout during the tests
  • Use localhost as default edgeDNSServer to avoid network timeout

ytsarev added 4 commits June 4, 2021 15:35
@ytsarev
Use edgeDNSServer for NS name resolution
5dd083a 
Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Optimize EdgeDNSServer config in tests
1c54df0 
* Make localhost default EdgeDNSServer in tests
* Override config in tests with external Cloudflare edgeDNS

Otherwise there will be network i/o timeouts which affect
overall test suite performance.

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Simplify GetExternalTargets
37694a2 
Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
DRY out GetExternalTargets more
917387e 
Signed-off-by: Yury Tsarev <[email protected]>
kuritka
kuritka requested changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fix tests, I have some points to consider

@ytsarev ytsarev requested a review from kuritka June 8, 2021 11:23
@ytsarev
Copy link
Member Author

ytsarev commented Jun 8, 2021

@kuritka thanks for the careful review, amended, please double check

@ytsarev ytsarev mentioned this pull request Jun 8, 2021
Merged
@ytsarev
Semantic renaming
25722e8 
Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev ytsarev merged commit 66d2929 into master Jun 8, 2021
@ytsarev ytsarev deleted the useEdgeDNSforNS branch June 8, 2021 21:43
@ytsarev ytsarev mentioned this pull request Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuritka kuritka kuritka approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytsarev @kuritka