Fix local playground setup #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't create service and don't point publish service to it. Istead use node IPs as Ingress address Signed-off-by: Dinar Valeev <[email protected]>
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
|
fixes #528 |
kuritka
approved these changes
Jun 21, 2021
|
@k0da sorry if I missed it, was the issue for terratest extension created before the merge? |
kuritka
added a commit
that referenced
this pull request
Jun 21, 2021
related to #532 terratest guarantees that ingress IP's are compatible with node internal IP's | | k3d-test-gslb1 | k3d-test-gslb2 | |--------------------|-----------------------------|-----------------------------| | server-0 | `192.168.16.2` | `192.168.16.4` | | agent-0 | `192.168.16.3` | `192.168.16.5` | | test-gslb-failover | `192.168.16.4,192.168.16.5` | `192.168.16.4,192.168.16.5` | | test-gslb | `192.168.16.2,192.168.16.3` | `192.168.16.2,192.168.16.3` | Signed-off-by: kuritka <[email protected]>
|
@k0da thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create service and don't point publish service to it. Istead use
node IPs as Ingress address
Signed-off-by: Dinar Valeev [email protected]