Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8gb prefix for external dns rbac #551

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Use k8gb prefix for external dns rbac #551

merged 1 commit into from
Jul 26, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jul 23, 2021

Signed-off-by: Yury Tsarev [email protected]

Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to change POD's sa then.

* Use k8gb prefix for rbac resources to avoid the conflict
  with the standard upstream external-dns names
* Fixes #542

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev ytsarev force-pushed the externaldns-rbac branch from 02ce33a to bb85b44 Compare July 23, 2021 11:22
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ytsarev ytsarev merged commit a19a328 into master Jul 26, 2021
@ytsarev ytsarev deleted the externaldns-rbac branch April 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't deploy K8GB in a Cluster that has an Existing ExternalDNS Deployment
2 participants