Gslb Controller Unit Tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First set of unit tests to support contoller development * Based on https://github.com/operator-framework/operator-sdk/blob/master/doc/user/unit-testing.md * Instead of constructing complex Gslb type with Go type declaration(which is really painful) we use https://github.com/ghodss/yaml/ to serialize inline Yaml manifest and make testing easier * Inspired by kubernetes/client-go#193 (comment)) * All API calls are mocked with fake client * Current coverage: * check if child Ingresses are created * check if Status properly reflect ManagedHosts * check if Status properly reflect non existing Service status * Further on we might want to test additional permutations
* We inherit Errcheck failures with operators-sdk * Fixes are in master operator-framework/operator-sdk@v0.12.0...master * Latest release of v0.12.0 do not contain them yet
* Actually fix errcheck errors in our codebase without waiting for upstream * Enable errcheck back in the pipeline
donovanmuller
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declaration(which is really painful) we
use https://github.com/ghodss/yaml/ to serialize inline Yaml manifest and make testing easier