Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all the static analysis tools, tests, etc. against the pull requests #608

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Sep 8, 2021

see issue #607

Signed-off-by: Jirka Kremser [email protected]

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, GH actions do not support YAML anchors

image

https://github.yoyoweb123.workers.devmunity/t/support-for-yaml-anchors/16128/44

@ytsarev
Copy link
Member

ytsarev commented Sep 8, 2021

Please also use special keyword in commit message https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Like fixes #607 so the issue will be automatically closed after the PR merge

@jkremser
Copy link
Member Author

jkremser commented Sep 8, 2021

Please also use special keyword in commit message

It's actually there in the commit message, or do you prefer to have it in the pull request description? Not sure if it also works, was always placing it to the commit message.

I will "expand" the anchors.. there will be a lot of duplicities, though.

@jkremser jkremser merged commit 7149515 into k8gb-io:master Sep 8, 2021
@jkremser jkremser deleted the issue-607 branch September 8, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants