Ability to disable IRSA role association in route53 scenario #614
Conversation
ytsarev
requested review from
donovanmuller,
jkremser,
k0da,
kuritka and
somaritane
as code owners
| @@ -29,7 +29,7 @@ kind: ServiceAccount | |||
| metadata: | |||
| name: k8gb-external-dns | |||
| namespace: {{ .Release.Namespace }} | |||
| {{ if .Values.route53.enabled }} | |||
| {{ if and .Values.route53.enabled .Values.route53.irsaRole }} | |||
There was a problem hiding this comment.
If we do this oposite?
{{ if .Values.route53.irsaRole }}
There was a problem hiding this comment.
Well irsaRole asumes you have route53 is enabled
There was a problem hiding this comment.
that's exactly the logic I want to convey. if route53 enabled AND irsaRole is specified then inject the annotation. Do you see any problem with this logic?
There was a problem hiding this comment.
It is duplicit and hard to read
There was a problem hiding this comment.
but also not a rocket science and more reliable
There was a problem hiding this comment.
Also it enables us to keep example at https://github.com/k8gb-io/k8gb/blob/master/chart/k8gb/values.yaml#L68 and not forcing it to false.
There was a problem hiding this comment.
@k0da also added inline clarification comment please re-review
* Fixes #593 * To disable just set `irsaRole` to `false` Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
force-pushed
the
optional-irsa
branch
from
4eb6d2b to
1e03084
Compare
irsaRoletofalseSigned-off-by: Yury Tsarev [email protected]