Update Offline Changelog #669
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: GitHub <[email protected]>
github-actions
bot
requested review from
donovanmuller,
jkremser,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 5f5c006 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/617009dbabf1b3000731a4a3 😎 Browse the preview: https://deploy-preview-669--k8gb-preview.netlify.app/changelog |
CHANGELOG.md
Outdated
| @@ -1,5 +1,115 @@ | |||
| # Changelog | |||
|
|
|||
| ## [Unreleased](https://github.com/k8gb-io/k8gb/tree/HEAD) | |||
There was a problem hiding this comment.
Whether to show the "unreleased entries" can be controlled on the gh action level. This auto pr is opened from the action that is run against the tag vX.Y.Z -> release, however this action has failed (gh api limits) and meanwhile some commits/prs/issues have landed to master, then this action was re-run from gh web ui and it figured out there were some changes so it's showing them.
I think we should set the unreleased to false in order to suppress these entries. I have a PR opened that does also this. What do you mean by moving the tag? Delete and recreate on the tip of the master? That would trigger the new release, no? I'd rather tweak this pr and hide the unreleased section (in ad-hoc / manual fashion this time)
There was a problem hiding this comment.
I think this should be closed
There was a problem hiding this comment.
@jkremser by moving tag i mean recreating the v0.8.3 release with the tip of the master yes.I am not sure if it is actually required in this specific case, so up to you to decide
Signed-off-by: Jirka Kremser <[email protected]>
|
@k0da why closing, we would lost the change log for |
|
@jkremser right!. LGTM |
There was a problem hiding this comment.
LGTM, though would be good to understand why some lines end up in other sections as @somaritane pointed out :)
Automated changes by create-pull-request GitHub action