Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using non-default token for opening the PR #696

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Using non-default token for opening the PR #696

merged 1 commit into from
Oct 26, 2021

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Oct 26, 2021 •
edited
Loading

The default one doesn't have the right to open a PR from public fork and fails on this.

The blog post says:
The rights for the default GITHUB_TOKEN can be fine tuned, but it also says:

Pull requests from public forks are still considered a special case and will receive a read token regardless of these settings.

Signed-off-by: Jirka Kremser [email protected]

k0da
k0da approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope the one have correct permissions

@jkremser jkremser merged commit 1ae2e42 into k8gb-io:master Oct 26, 2021
@jkremser jkremser deleted the olm-bundle-fix3 branch October 26, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

@somaritane somaritane Awaiting requested review from somaritane

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkremser @k0da