Fix upgrade-candidate

[kuritka]

upgrade-candidate - the target for deploying the current version of
k8gb to local k3d clusters tried to deploy a local image that did not exist.
Here is the fix.

Signed-off-by: kuritka [email protected]

[ytsarev]

It probably duplicates the build step in the pipeline

[kuritka]

It probably duplicates the build step in the pipeline

going to fix

[k0da]

Yes.

• name: Build artifacts
  uses: goreleaser/goreleaser-action@v2
  with:
  version: latest
  args: release --rm-dist --skip-publish --skip-validate --snapshot
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[kuritka]

All green, can be reviewed again...

[ytsarev]

Suggested change

	deploy-semver: ## Upgrade k8gb to the test version on existing clusters
	deploy-test-version: ## Upgrade k8gb to the test version on existing clusters

I might be missing something but deploy-semver is a bit confusing target name here

[kuritka]

The main idea for naming is we operate with stable[1], [2] [3] and semver [4] terms. I was trying to keep same semantics.

Maybe can rename both (deploy-stable, deploy-semver)

[jkremser]

Agreed, using the word semver in this context is quite misleading. Semantic versioning talks about the versioning scheme, when to raise each component of that x.y.z triplet. So even the stable actually deploys a version (latest released in dockerhub) that conforms the semver.

The makefile also operate with word "candidate", this is much closer to what it is, imho. Or test-version or latest vs latest-released(=stable).

The version/container tag it actually produces looks like x.y.z-gitsha and from what I've seen it's pretty much the same semantics as the x.y.z-SNAPSHOT versions from the Java world

[kuritka]

@ytsarev , @jkremser, naming fixed

[k0da]

It still duplicates build, GHA builds image already

[kuritka]

@k0da are you sure? upgrade-testing.yaml runs exactly same code as before , just target renamed from upgrade-candidate to deploy-test-version.

upgrade-candidate now builds locally + still fits with all documentation.

[ytsarev]

lgtm, thanks!

[k0da]

@k0da are you sure? upgrade-testing.yaml runs exactly same code as before , just target renamed from upgrade-candidate to deploy-test-version.

upgrade-candidate now builds locally + still fits with all documentation.

https://github.com/k8gb-io/k8gb/blob/master/.github/workflows/upgrade-testing.yaml#L29