Update AWS/Route53 reference setup terraform code #717
Conversation
ytsarev
requested review from
donovanmuller,
jkremser,
k0da,
kuritka and
somaritane
as code owners
|
✔️ Deploy Preview for k8gb-preview ready! 🔨 Explore the source changes: 2119618 🔍 Inspect the deploy log: https://app.netlify.com/sites/k8gb-preview/deploys/618a539731376f0008268b4f 😎 Browse the preview: https://deploy-preview-717--k8gb-preview.netlify.app |
docs/deploy_route53.md
Outdated
| @@ -8,8 +8,12 @@ Two EKS clusters in `eu-west-1` and `us-east-1`. | |||
|
|
|||
| Terraform code for cluster reference setup can be found [here](https://github.com/k8gb-io/k8gb/tree/master/docs/examples/route53) | |||
|
|
|||
| Feel free to reuse this code fully or partially and adapt for your existing scenario | |||
| things like IRSA(IAM Roles for Service Accounts). | |||
| Feel free to reuse this code fully or partially and adapt for your existing scenario custom configuration like | |||
There was a problem hiding this comment.
nit: "..iguration like.." (2 spaces) Markdown + jekyll fixes this, but still
There was a problem hiding this comment.
@jkremser amended, thanks for the catch.
* Update with the recent enhancements and terraform >= 1.0 compatibility fixes * Documentation update Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
force-pushed
the
aws-ref-setup-up
branch
from
a4e73f0 to
eb27848
Compare
| @@ -1,2 +1,3 @@ | |||
| .terraform | |||
| .terraform* | |||
| terraform.tfstate* | |||
There was a problem hiding this comment.
inspired by Terraform.gitignore; consider sensitive *.tfvars
There was a problem hiding this comment.
@kuritka we are not passing tfvars here at all, but doing it through the module invocation see main.tf
There was a problem hiding this comment.
@ytsarev , ah, clear now. Thx
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
force-pushed
the
aws-ref-setup-up
branch
from
1b94910 to
2119618
Compare
fixes
Signed-off-by: Yury Tsarev [email protected]