switch hostAlias to real edgeDNS #726
Conversation
k0da
requested review from
donovanmuller,
jkremser,
kuritka,
somaritane and
ytsarev
as code owners
k0da
force-pushed
the
edge
branch
5 times, most recently
from
922be2b to
421c8d8
Compare
k0da
force-pushed
the
edge
branch
8 times, most recently
from
1ed3319 to
ecab83d
Compare
k0da
changed the title
k0da
force-pushed
the
edge
branch
6 times, most recently
from
0d3002b to
f178bcc
Compare
k0da
force-pushed
the
edge
branch
4 times, most recently
from
1594489 to
ed6a7a5
Compare
k0da
force-pushed
the
edge
branch
9 times, most recently
from
e701529 to
1094152
Compare
There was a problem hiding this comment.
pls, leave the support for host aliases in helm
We should probably update the docs later on (local playground needs to be changed/improved to make podinfo working in the browser) and also mention somewhere that it's not meant to be used in production, unless the credentials are changed, like in the original tutorial.
otherwise looks good to me. I've tested the branch locally by:
make deploy-full-local-setup CLUSTERS_NUMBER=2 CHART='./chart/k8gb'
# CHART='./chart/k8gb' is required here, because the changes in helm haven't been released yet
dig @localhost -p 1053 roundrobin.cloud.example.com +short
172.19.0.8
172.19.0.7
172.19.0.3
172.19.0.4
172.19.0.5
172.19.0.6
k scale deployment frontend-podinfo -n test-gslb --replicas 0 --context k3d-test-gslb1
dig @localhost -p 1053 roundrobin.cloud.example.com +short
172.19.0.8
172.19.0.7
172.19.0.5
172.19.0.6
k scale deployment frontend-podinfo -n test-gslb --replicas 0 --context k3d-test-gslb2
dig @localhost -p 1053 roundrobin.cloud.example.com +short
172.19.0.8
172.19.0.7
k scale deployment frontend-podinfo -n test-gslb --replicas 1 --context k3d-test-gslb1
dig @localhost -p 1053 roundrobin.cloud.example.com +short
172.19.0.3
172.19.0.4
172.19.0.5
172.19.0.6
good stuff @k0da 👍
| @@ -209,6 +215,9 @@ deploy-k8gb-with-helm: | |||
| --set k8gb.imageTag=${VERSION:"stable"=""} \ | |||
| --set k8gb.log.format=$(LOG_FORMAT) \ | |||
| --set k8gb.log.level=$(LOG_LEVEL) \ | |||
| --set rfc2136.enabled=true \ | |||
| --set k8gb.edgeDNSServers[0]=$(CLUSTER_GSLB_GATEWAY):1053 \ | |||
| --set externaldns.image=absaoss/external-dns:rfc-ns1 \ | |||
There was a problem hiding this comment.
what were the changes in absaoss/external-dns:rfc-ns1, where is it being built (/dockerfile)? Is it the upstream repo + this PR kubernetes-sigs/external-dns#2439 ?
There was a problem hiding this comment.
Yes, exactly. This is built from branch make build.mini
| {{- if .Values.k8gb.hostAliases }} | ||
| hostAliases: | ||
| {{- toYaml .Values.k8gb.hostAliases | nindent 8 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Can't we leave this here and also in values.yaml as an alternative option? These still can co-exist, right? 0 support on the "makefile level", but leaving the option there would be a safe thing to do, imho
There was a problem hiding this comment.
I'd like to drop fall back from controller as well, right now it is quite confusing
k0da
force-pushed
the
edge
branch
2 times, most recently
from
86de21e to
1e53039
Compare
k0da
force-pushed
the
edge
branch
3 times, most recently
from
746b172 to
e591931
Compare
|
rebased against master to include k3d-action@v2 and drop temporary k3d hack |
This runs rfc2136 provider and remove all local hacks Signed-off-by: Dinar Valeev <[email protected]>
This runs rfc2136 provider and remove all local hacks
Signed-off-by: Dinar Valeev [email protected]