Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose all namespaces in ServeCRMetrics #73

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Expose all namespaces in ServeCRMetrics #73

merged 2 commits into from
Mar 31, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Mar 31, 2020

  • It makes :8686/metrics endpoint expose CR metrics
    in all namespaces, not only operator one
  • In our case it is requirement as the ohmyglb is a
    cluster-scoped operator - Gslb CRs are getting created
    in multiple app centric namespaces which names we cannot
    predict

@ytsarev
Expose all namespaces in ServeCRMetrics
44a22a8 
* It makes `:8686/metrics` endpoint expose CR metrics
  in all namespaces, not only operator one
* In our case it is requirement as the ohmyglb is a
  cluster-scoped operator - `Gslb` CRs are getting created
  in multiple app centric namespaces which names we cannot
  predict
@ytsarev ytsarev requested a review from donovanmuller March 31, 2020 15:09
@ytsarev
Copy link
Member Author

ytsarev commented Mar 31, 2020 

curl localhost:8686/metrics
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
# HELP gslb_info Information about the Gslb custom resource.
# TYPE gslb_info gauge
gslb_info{namespace="test-gslb",gslb="test-gslb"} 1

@ytsarev ytsarev requested a review from somaritane March 31, 2020 15:18
somaritane
somaritane approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ytsarev ytsarev merged commit de2670f into master Mar 31, 2020
@ytsarev ytsarev deleted the metrics-namespaces branch March 31, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somaritane somaritane somaritane approved these changes

@donovanmuller donovanmuller donovanmuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytsarev @somaritane @donovanmuller