Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terratest e2e testing proposal #74

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Terratest e2e testing proposal #74

merged 2 commits into from
Apr 1, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 1, 2020

This PR contains simple example of ohmyglb testing
with https://terratest.gruntwork.io/

I see multiple benefits using this framework:

This PR contains simple example of ohmyglb testing
with https://terratest.gruntwork.io/

I see multiple benefits using this framework:

* It supports kubernetes visibly well with resonable amount of k8s modules
  https://github.com/gruntwork-io/terratest/tree/master/modules/k8s
* It has bunch of useful testing helpers like
  https://github.com/gruntwork-io/terratest/tree/master/modules/http-helper
* It's a golang so we are staying in context with the main codebase
@ytsarev ytsarev force-pushed the terratest-experiment branch from ee26512 to ad23e5e Compare April 1, 2020 14:32
Copy link
Contributor

@donovanmuller donovanmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean 👍

* We want to avoid dependency failures in main application `go mod`
* We don't want to install `terratest` and all its dependencies
  next to the main ohmyglb packages by default
@ytsarev ytsarev merged commit de5f913 into master Apr 1, 2020
@ytsarev ytsarev deleted the terratest-experiment branch April 1, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants