Extend cut_release GHA workflow with release revert mechanism #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Delete tag and release on associated revert commit * Conditional expression fix/simplification according to https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idif Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
requested review from
donovanmuller,
jkremser,
k0da,
kuritka and
somaritane
as code owners
jkremser
previously approved these changes
Nov 16, 2021
There was a problem hiding this comment.
looks good, but might be dangerous if someone deletes the tag manually and then also does the revert. That would delete the last but one release.
We might be paranoid and check if the version we are downgrading into in the Chart.yaml == git describe --abbrev=0 --tags ${tag}^ (previous tag in git)
Probably overkill, though + we should be able to catch this in the PR review
|
@jkremser really good point, let me try to amend |
Signed-off-by: Yury Tsarev <[email protected]>
|
@jkremser amended, please check |
Signed-off-by: Yury Tsarev <[email protected]>
k0da
previously approved these changes
Nov 16, 2021
jkremser
requested changes
Nov 16, 2021
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
|
@jkremser make sense, amended |
jkremser
approved these changes
Nov 16, 2021
|
Release tag and release deletion tested in my fork https://github.com/ytsarev/k8gb/runs/4226165824?check_suite_focus=true |
k0da
approved these changes
Nov 16, 2021
kuritka
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idif
Signed-off-by: Yury Tsarev [email protected]