Allow the EXT_GSLB_CLUSTERS_GEO_TAGS to contain CLUSTER_GEO_TAG #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
kuritka
requested changes
Nov 19, 2021
Signed-off-by: Jirka Kremser <[email protected]>
jkremser
force-pushed
the
ext-geo-clusters-include
branch
from
6250f8b to
af700c5
Compare
kuritka
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's addressing the first point in the #720 and basically we can ignore the value of
CLUSTER_GEO_TAGif it's in theEXT_GSLB_CLUSTERS_GEO_TAGSlist during the start of the application so that no other changes to code are needed (=> backward compatible change)Signed-off-by: Jirka Kremser [email protected]