Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terratest e2e for Failover strategy #79

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Terratest e2e for Failover strategy #79

merged 2 commits into from
Apr 7, 2020

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 7, 2020

  • Utilizes 2 local clusters deployed by make deploy-full-local-setup
  • Creates Gslb CRs in both clusters with Failover strategy
  • Checks expected DNS response on the main cluster
  • Makes workload unhealthy on the main cluster
  • Checks that DNS response contains IP list from secondary cluster
    proving that Failover works

* Utilizes 2 local clusters deployed by `make deploy-full-local-setup`
* Creates `Gslb` CRs in both clusters with Failover strategy
* Checks expected DNS response on the main cluster
* Makes workload unhealthy on the main cluster
* Checks that DNS response contains IP list from secondary cluster
  proving that Failover works

Note: timeouts are still a problem. We might need to extend
terratest `retry` package to wait for expected value with
retry and timeout threshold.
@donovanmuller
Copy link
Contributor

@ytsarev Correct me if I'm wrong but these e2e tests are not yet added to the build pipeline yet?

@ytsarev
Copy link
Member Author

ytsarev commented Apr 7, 2020

@donovanmuller not yet... I'm slowly crawling to prove #67 programmable way :) We will include all of them into the pipeline as part of #48 and 0.7 release

Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

* Extend some concepts from `terratest/modules/retry`
  to create function that will retry until specific threshold
* If the function gets expected value it returns immediately
  so we avoid hardcoded sleep based timeout
@ytsarev ytsarev requested review from donovanmuller and kuritka April 7, 2020 19:22
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ytsarev ytsarev merged commit 426b8f1 into master Apr 7, 2020
@ytsarev ytsarev deleted the terratest-failover branch April 7, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants