Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-linter pipeline and helm template fix #801

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

somaritane
Copy link
Contributor

@somaritane somaritane commented Dec 13, 2021

Fixes #800

  • Updated kuber-linter-actions to v1 (=v1.0.4)
  • Fixed kube-linter version to 0.2.5
  • Added support for sarif analysis
  • Fixed problematic helm templates

kudos to @jkremser for finding the proper fix for COREDNS_EXPOSED env var rendering!

Signed-off-by: Timofey Ilinykh [email protected]
Co-authored-by: Yury Tsarev [email protected]

kuritka
kuritka previously approved these changes Dec 14, 2021
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is cleaner to move yaml separator under condition instead of total removal

- Updated kuber-linter-actions to v1 (=v1.0.4)
- Fixed kube-linter version to 0.2.5
- Added support for sarif analysis
- Fixed problematic helm templates

Signed-off-by: Timofey Ilinykh <[email protected]>
Co-authored-by: Yury Tsarev <[email protected]>
@somaritane somaritane force-pushed the fix-kubelinter-pipeline branch from 8aa3808 to 9f4b1df Compare December 14, 2021 08:28
@somaritane
Copy link
Contributor Author

I think it is cleaner to move yaml separator under condition instead of total removal

Agree, amended :)

@somaritane somaritane merged commit 85c5982 into master Dec 14, 2021
@somaritane somaritane deleted the fix-kubelinter-pipeline branch December 14, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: Fix kube-linter github workflow
4 participants