Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Don't .gitignore chart/k8gb/ directory #802

Merged
merged 1 commit into from
Dec 15, 2021
Merged

dev: Don't .gitignore chart/k8gb/ directory #802

merged 1 commit into from
Dec 15, 2021

Conversation

somaritane
Copy link
Contributor

@somaritane somaritane commented Dec 14, 2021 •
edited
Loading

.gitgignore k8gb binary but not chart/k8gb/ directory.
Masking chart/k8gb/ byk8gb rule prevents adding changes and new templates into the k8gb chart.

Signed-off-by: Timofey Ilinykh [email protected]
Co-authored-by: Jirka Kremser [email protected]

k0da
k0da previously approved these changes Dec 14, 2021
View reviewed changes
jkremser
jkremser requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@jkremser jkremser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart/k8gb/ is not ignored at the moment so I am not sure what this change aims to achieve

the chart/k8gb/charts/*.tgz rule should be ok imho and should not ignore anything important

edit1: I don't think it's clashing with the k8gb rule on this line. I can make changes to chart templates, value.yaml and other files and these are not ignored. We can be more explicit and do: k8gb -> /k8gb and k8gb.exe -> /k8gb.exe

edit2: got ya now, the new files in that dir are not being tracked.. so after touch chart/k8gb/sdf sdf is not recognized.. hmm, then can we have perhaps this instead:

diff --git .gitignore .gitignore
index 865e9f4..75f7399 100644
--- .gitignore
+++ .gitignore
@@ -1,8 +1,8 @@
 dist/
 *.out
 *.sw[ap]
-k8gb
-k8gb.exe
+/k8gb
+/k8gb.exe
 .env

the less rules, the better, right?

@somaritane somaritane force-pushed the dont-gitignore-helm-chart branch from b0aff1d to 6323d3b Compare December 14, 2021 19:53
@somaritane
Copy link
Contributor Author

the less rules, the better, right?

Nice spot @jkremser, amended!

@somaritane somaritane requested review from jkremser and k0da December 14, 2021 19:54
ytsarev
ytsarev requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear description to me as well, chart/k8gb was never ignored. Please update the commit message

@somaritane
Copy link
Contributor Author

Not clear description to me as well, chart/k8gb was never ignored. Please update the commit message

@ytsarev Mind to help with description? :) It was in fact ignored, not explicitly but transitively by k8gb rule

@somaritane somaritane force-pushed the dont-gitignore-helm-chart branch from 6323d3b to 682642b Compare December 14, 2021 20:51
@somaritane
Copy link
Contributor Author

Not clear description to me as well, chart/k8gb was never ignored. Please update the commit message

@ytsarev rephrased commit message, please check

@somaritane somaritane requested a review from ytsarev December 14, 2021 20:53
jkremser
jkremser previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@jkremser jkremser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ytsarev
ytsarev previously approved these changes Dec 14, 2021
View reviewed changes
@somaritane @jkremser
.gitgignore k8gb binary but not chart/k8gb/ directory.
bfe8f31 
Masking chart/k8gb/ byk8gb rule prevents adding changes and new templates into the k8gb chart.

Signed-off-by: Timofey Ilinykh <[email protected]>
Co-authored-by: Jirka Kremser <[email protected]>
@somaritane somaritane dismissed stale reviews from ytsarev and jkremser via bfe8f31 December 14, 2021 23:03
@somaritane somaritane force-pushed the dont-gitignore-helm-chart branch from 682642b to bfe8f31 Compare December 14, 2021 23:03
kuritka
kuritka approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding, thx 👍

@somaritane somaritane merged commit 1edf72a into master Dec 15, 2021
@somaritane somaritane deleted the dont-gitignore-helm-chart branch December 15, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuritka kuritka kuritka approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@somaritane @ytsarev @jkremser @k0da @kuritka