Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all GHA to checkout v2 #814

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Upgrade all GHA to checkout v2 #814

merged 2 commits into from
Dec 21, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Dec 21, 2021

Signed-off-by: Yury Tsarev [email protected]

k0da
k0da previously approved these changes Dec 21, 2021
kuritka
kuritka previously approved these changes Dec 21, 2021
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was so obvious that everyone overlooked it 😄 .

Copy link
Member

@jkremser jkremser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

perhaps we need to do

with:
   fetch-depth: 0

so that this works properly: https://github.com/k8gb-io/k8gb/blob/master/Makefile#L69

related: actions/checkout#338

@ytsarev ytsarev dismissed stale reviews from kuritka and k0da via 89a01a4 December 21, 2021 14:41
Copy link
Member

@jkremser jkremser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ytsarev ytsarev merged commit e300db0 into master Dec 21, 2021
@ytsarev ytsarev deleted the checkout-bump branch December 21, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants