Make make colorful

[jkremser]

what:
s/@echo/@echo -e/g in Makefile

why:

the SHELL := bash on line 36 is causing this:

make deploy-full-local-setup
\n\033[0;33mCreating 2 k8s clusters\033[0m
/Library/Developer/CommandLineTools/usr/bin/make create-local-cluster CLUSTER_NAME=edge-dns
\n\033[0;33mCreate local cluster \033[1;36medge-dns \033[0m
k3d cluster create -c k3d/edge-dns.yaml
INFO[0000] Using config file k3d/edge-dns.yaml (k3d.io/v1alpha3#simple)
INFO[0000] Prep: Network
..

i.e. echo doesn't interpret the escape characters for colors, nor the new lines. Colors can be fixed like this, but new lines (\n) require the echo -e .. (which also fixes the colors)

after:

Signed-off-by: Jirka Kremser [email protected]

[somaritane]

LGTM 👍

[kuritka]

@jkremser would there be any advantages/disadvantages to using SHELL := /bin/sh instead of the -e (in combination with /bin/bash) argument ?

[jkremser]

@kuritka SHELL := /bin/sh would ran into the issue that on Ubuntu this points to the Dash implementation..

❯ docker run -ti --rm --entrypoint="" ubuntu ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Jul 18  2019 /bin/sh -> dash

[kuritka]

@jkremser , Thank you for the explanation, lgtm