Test mutual failover setup #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves #67 * Proves expected behavior of primary-primary failover setup * Move common test function to `helpers.go` ``` --- PASS: TestOhmyglbSplitFailoverExample (230.45s) --- PASS: TestOhmyglbSplitFailoverExample/Each_cluster_resolves_its_own_set_of_IP_addresses (30.53s) --- PASS: TestOhmyglbSplitFailoverExample/serviceHealth_becomes_Unhealthy_after_scaling_down_to_0 (10.17s) --- PASS: TestOhmyglbSplitFailoverExample/Cluster_1_failovers_to_Cluster_2 (61.28s) --- PASS: TestOhmyglbSplitFailoverExample/Cluster_2_still_returns_own_entries (0.07s) ```
| assert.Equal(t, afterFailoverResponse, expectedIPsCluster2) | ||
| }) | ||
|
|
||
| t.Run("Cluster 2 still returns own entries", func(t *testing.T) { |
There was a problem hiding this comment.
@ytsarev would it be worth adding an additional step. Test if the service from Cluster 1 becomes healthy once more, that Cluster 1 should then continue to resolve its own IP addresses? I.e. it fails back again.
So:
- Cluster 1 resolves it's own addresses
- Service becomes unhealthy on Cluster 1
- Cluster 2 addresses are now resolved only
- Service becomes healthy again on Cluster 1
- Cluster 1 once again resolves it's own addresses
There was a problem hiding this comment.
totally, will add this step, thanks!
There was a problem hiding this comment.
@donovanmuller implemented, please review
kuritka
approved these changes
Apr 9, 2020
donovanmuller
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helpers.go