Fix #881: gslbs and/or ingresses require the ingressClassName to be there #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be populated Signed-off-by: Jirka Kremser <[email protected]>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k0da
approved these changes
Apr 29, 2022
somaritane
approved these changes
Apr 29, 2022
(I will open an issue, because they are green even though there is a failure (that's why we were missing this issue)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the field is empty, the nginx controller simply ignores it:
However, if nginx-controller ignores it, it does not populate the IPs under Ingress'
status.loadBalancerfield and our k8gb controller won't get the IPs.There is also a way to say nginx to handle ingresses w/o any class on it (https://github.com/nginxinc/kubernetes-ingress/blob/main/deployments/helm-chart/values.yaml#L158) but it's turned-off by default and I think we should be explicit here. Having the class there also allows for multiple ingress controllers in the cluster.
The change in
terratest/test/k8gb_ingress_annotation_rr_test.gowas necessary, because the order of things in the map is different now + the name was different. The way how we check the equivalency on the maps is quite bad though.. it's string based. it would require more love, but I wanted to have a quick fix ready, so that the terratests are green again.Signed-off-by: Jirka Kremser [email protected]